Git Product home page Git Product logo

Comments (21)

kaspermarstal avatar kaspermarstal commented on August 18, 2024 5

Yes! I am planning to fix this build as soon as I get the SimpleITK v1.1.0 branch merged.

If anyone wants to take an initial stab at the conda build you are very welcome!

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024 2

We will use azure pipelines to build python packages. Thank you for the contributions for far!

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024 1

I met with @blowekamp at a conference yesterday who suggested to strip out the SimpleITK filters to reduce compilation time. I am working on this atm and it looks like this does indeed bring the compilation time down to under an hour. Hope to commit the changes in the next couple of days!

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024

Hi almarklein, yes that would be very helpful for a lot of users. I do not have much experience with conda-forge, would you be interested in contributing such a recipe?

from simpleelastix.

almarklein avatar almarklein commented on August 18, 2024

I don't have a lot of time on my hands, but I do believe the Python community needs a tool like this to be easily available. What if I did the initial setup, and then ping you to sort out the details of the build.sh and build.bat?

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024

That would be great! Awesome! Got your ping, will take a look this afternoon.

from simpleelastix.

almarklein avatar almarklein commented on August 18, 2024

I gave you push-rights to the repo, in case you feel like fixing things :) I have no idea where to start with the Windows .bat file.

Links for reference:

from simpleelastix.

almarklein avatar almarklein commented on August 18, 2024

BTW: what versions of Python does SimpleElastix' wrapper support?

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024

For sure Python 2.7 and 3.4. Haven't tested with 3.5 but would be surprised if it didnt work

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024

I think we might have a problem with the build time. I don't have experience with Circle CI or AppVeyor, but Travis CI limits build time to 50 minutes which is barely enough time to build ITK and elastix, let alone SimpleElastix. Don't know what to do about that

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024

Thanks for push-rights btw, I will handle the Windows build :)

from simpleelastix.

chvlyl avatar chvlyl commented on August 18, 2024

I wonder if SimpleElastix can be installed by anaconda?
I added conda-forge as a new channel but can't find SimpleElastix.
Here is my code:
conda config --add channels conda-forge
conda install SimpleElastix

I got the following error message:
PackageNotFoundError: Package not found: '' Package missing in current osx-64 channels:

  • simpleelastix

Is it because my mac OSX version (10.9.5) is too old?

Any help is appreciated. Thanks!

from simpleelastix.

almarklein avatar almarklein commented on August 18, 2024

@chvlyl The package is not yet available. It turned out to be a lot of work to create the recipe, with problems that include that the build takes longer than the maxium allowed time for a CI job.

@kaspermarstal I know you've already put a lot of effort in. What is the latest status, more or less? There seem to be plenty of ppl interested in this, maybe we can do a call-out for help, e.g. in the scikit-image community.

from simpleelastix.

blowekamp avatar blowekamp commented on August 18, 2024

Hi,

It was nice meeting you. I am still at the conference, if you want to meet up to discuss this issue further.

Here is our condo-forge pull request, with some ideas on how we are going to move forward:
conda-forge/staged-recipes#1045

Away to help choose the components too keep to is to take advantage of ITK modularity. Has Elastix its self taken advantage of the ITK modularity? Does it build ITK with all the default modules on? A list of modules that Elastix need could be generated. And then the build of ITK could only specify the required modules.

A feature that is coming to SimpleITK, is that in each JSON file is going to specify the ITKModule it is located in. Then when building against ITK, the JSON will automatically be disabled if the ITKModule is not enabled.

Yes another way to reduce the size is to disable some pixel types, perhaps std::complex or LabelMap are not needed.

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024

Hi Bradley, yes nice to meet you too! I left this morning unfortunately, would have liked to talk again. But thanks for the suggestions. Build time is dropping slowly but steady.

from simpleelastix.

kaspermarstal avatar kaspermarstal commented on August 18, 2024

Hi @almarklein. I never got it working because it takes too long to build. Closing because it has taken too long to get it to work for me. Feel free to reopen if you want to have another go at it.

from simpleelastix.

almarklein avatar almarklein commented on August 18, 2024

Hi @kaspermarstal, no problem, thanks for trying!

from simpleelastix.

PertuyF avatar PertuyF commented on August 18, 2024

@kaspermarstal could independent itk and libitk conda packages be of interest to speed up the build?

from simpleelastix.

cancan101 avatar cancan101 commented on August 18, 2024

@PertuyF that is the approach that pyfftw takes where pyftw depends on fftw (https://github.com/conda-forge/pyfftw-feedstock/blob/master/recipe/meta.yaml#L27) so that the build is broken up.

from simpleelastix.

hmaarrfk avatar hmaarrfk commented on August 18, 2024

This is really exciting! as I'm having alot of trouble installing things on Fedora 28.

Is it possible to reopen this issue in light of recent enthusiasm?

from simpleelastix.

soupault avatar soupault commented on August 18, 2024

I'm having alot of trouble installing things on Fedora 28.

I'm struggling even on Ubuntu (with and without Docker env). Would be glad to contribute here, although I made the compilation work, probably, 1 time out of 10. πŸ˜“

from simpleelastix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.