Git Product home page Git Product logo

Comments (1)

fnikolai avatar fnikolai commented on May 24, 2024

here is the job: https://github.com/SuperDuperDB/superduperdb/actions/runs/7906999810/job/21583069571

superduperdb.base.exceptions.ServiceRequestException: Server error at cdc with 400 :: {'error': 'Config is not match'}

The problem is that conftest.py effectively ignores the env variables, resulting into different configurations from CDC, Vector-search, ray-workers etc.
There are two reasons for that:

  1. It reads non-standard env variables like SUPERDUPER_MONGO_URI.
  2. Has hardcoded values.

Here are some examples from conftest.py

    data_backend = 'mongodb://superduper:superduper@mongodb:27017/test_db'
    data_backend = os.environ.get('SUPERDUPER_MONGO_URI', data_backend)
    db_name = data_backend.split('/')[-1]

    artifact_store = 'filesystem:///tmp/artifacts'
    monkeypatch.setattr(CFG, 'artifact_store', artifact_store)

Standard and Non-Standard Variables
The standard variables are only those defined in the Config (e.g SUPERDUPER_DATA_BACKEND ). The fact that a variable begins with SUPERDUPER does not make it standard. (e.g SUPERDUPER_MONGO_URI)

As Kartik said on a previous iteration, the reason for having non-standard variables is that we may want to test multiple databases (e.g, mongo, sql, etc).
So we cannot simply provide a SUPERDUPER_DATA_BACKEND .

I get the problem, but we cannot simply hardcode paths because we lose portability.

Possible Solution

Use SUPERDUPERDB_TEST_CONFIGS that will as input a JSON of different Datalayer configuration we want to test.

For example:

export SUPERDUPERDB_TEST_CONFIGS='[
  {
    "DATA_BACKEND": "mongodb://...",
    "COMPUTE_URI": "ray://localhost...",
    "ARTIFACT_STORES": "/artifacts"
  },
  {
    "DATA_BACKEND": "sql://...",
    "COMPUTE_URI": "ray://localhost...",
    "ARTIFACT_STORES": "/whatever"
  }
]'

from superduperdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.