StreamInterface vs resource. about flysystem-google-cloud-storage HOT 7 CLOSED

Thanks, we definitely should be returning a resource and not the StreamInterface, which we bubble down from the the Google Cloud lib - https://github.com/GoogleCloudPlatform/google-cloud-php/blob/master/src/Storage/StorageObject.php#L608

Whilst we've deviated from the interface, I'm not sure I'd like to consider it a breaking change. In the unit test, we incorrectly test for a StreamInterface, but in the actual class, we inheritdoc and say we return a resource (even though we don't).

I'm open to thoughts on this.

I'll patch it when I have a sec.
It looks like we should be calling \GuzzleHttp\Stream\GuzzleStreamWrapper:: getResource(...) to convert the StreamInterface to a PHP resource.

from flysystem-google-cloud-storage.

Well, if somebody is using that method and relying that to return StreamInterface, they might consider this a breaking change, if it's changed to resource :)

from flysystem-google-cloud-storage.

Any progress on this one?

from flysystem-google-cloud-storage.

I've merged this into master now.
Will push this into a 5.0.0 release.

from flysystem-google-cloud-storage.

This breaks MountManager::copy() which passes the buffer up to Filesystem::writeStream() and subsequently throws an exception.

I can confirm that the latest commit fixes this issue.

from flysystem-google-cloud-storage.

Yup. Hoping for a 5.0 release soon.

from flysystem-google-cloud-storage.

I've pushed a new major, 5.0.0 with the above fix.

https://github.com/Superbalist/flysystem-google-cloud-storage/releases/tag/5.0.0

Thanks!

from flysystem-google-cloud-storage.