Git Product home page Git Product logo

Comments (7)

matthewgoslett avatar matthewgoslett commented on June 3, 2024

cc @cedricziel

I'm not quite sure of the smoothest way forward here.

I'm suggesting we:

  1. Revert https://github.com/Superbalist/flysystem-google-storage/pull/6/files
  2. Create a new release fixing existing implementations.
  3. Create a new RC release allowing only RC2 to 2.0.0 and changing our code to support to the new credentials handling as per https://github.com/google/google-api-php-client/blob/master/UPGRADING.md#google_auth_assertioncredentials-has-been-removed

from flysystem-google-cloud-storage.

cedricziel avatar cedricziel commented on June 3, 2024

I'd say:

1.) Branch off 1.x, Remove the 2.0 constraint (or to cause less harm pin the last working RC) and release a new patch version as a fix for existing users
2.) on master, use a constraint on the final 2.0 client and tag a new major version

I'm pretty sure that's the way to go :)

from flysystem-google-cloud-storage.

cedricziel avatar cedricziel commented on June 3, 2024

So basically what you're saying, @matthewgoslett :D

from flysystem-google-cloud-storage.

matthewgoslett avatar matthewgoslett commented on June 3, 2024

I can't seem to find any RC version which still has the Google_Auth_AssertionCredentials class and old way of defining service credentials.
Can you confirm how you have it working your side, from when you requested the 2.0.0@RC be allowed?

from flysystem-google-cloud-storage.

matthewgoslett avatar matthewgoslett commented on June 3, 2024

Fixed in release 1.0.4 - https://github.com/Superbalist/flysystem-google-storage/releases/tag/1.0.4

I'm going to work on a new RC2 our side which uses the updated google/apiclient.
Apologies for the breakage here.

from flysystem-google-cloud-storage.

matthewgoslett avatar matthewgoslett commented on June 3, 2024

I've allowed for google/apiclient 2.0.0@RC in https://github.com/Superbalist/flysystem-google-storage/releases/tag/2.0.0-RC1

from flysystem-google-cloud-storage.

cedricziel avatar cedricziel commented on June 3, 2024

Thx Matthew - it's currently a bit out of scope, but I'll get back to testing and improving.

from flysystem-google-cloud-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.