Comments (6)
Seems there are some more occurrances: https://github.com/sunspec/models/search?utf8=β&q=var&type=
from models.
Just a comment: instead of introducing a new encoding format (json) it would be great to address the content problems, too. Those wonβt be solved by switching to json?
from models.
I completely agree that encoding format won't solve every problem. We are trying to achieve a number of things at the same time which hopefully represent improvements. It is our intention to resolve every open issue.
Relating to this issue, I think we are required to be very conservative about changes that may break existing implementations. The existing models are frozen and only open to certain kinds of backward compatible changes. For existing models, I do not think we can change the actual point names as that could break some current implementations. The new models that are developed and tested are certainly open to these types of changes.
from models.
@andig, perhaps we could write a custom checker to address these things? For units it could be based on the pysunspec lib and be run against any of the model formats. For some things like element order etc it would have to be format aware. Or perhaps in this case it can be achieved in the schemas by defining acceptable values? If the CI gets enabled at some point then everyone would know when they push something wrong rather than having to wait for someone to read it and find the errors (hopefully before lockdown?). The lockdown aspect that keeps us from changing existing models is exactly why extra care needs to be taken with automatic checks rather than just hoping people are really careful.
from models.
Also, there needs to be a path forward to fix locked down things. Possibly requiring new model numbers for otherwise the same models. I'm not sure if that's a part of the plan or not. Old units would still use the incorrect old models but new units would use the new corrected models that fulfill the same purpose. Or something... but 'if it is broken it always will be' is trouble.
from models.
In general, new model numbers are the standard way to fix broken frozen models. The 7xx models are both to provide 1547 required points and to also try to fix some of the fundamental aspects of the equivalent 1xx models which were confusing or broken such as curve update synchronization and reversion timer behavior. Along with more comprehensive documentation.
We are putting more model validation content in pysunspec and now have the schema to check against as well for general issues. I totally agree that we should do as much checking in the CI environment as possible.
from models.
Related Issues (20)
- Clarify behaviour of reversion timers HOT 4
- Model 704 WMaxLimPct and WSetPct HOT 3
- Model 701 InvSt - Shouldn't it have a "RUNNING" state? HOT 7
- DID 701 PF - Should be Signed? HOT 11
- Model 704/705 Reactive power control priority enumeration confusion HOT 3
- Model 702 | PFOvrExt/PFUndExt seem to be duplicates of WOvrExtPF/WUndExtPF HOT 1
- 700 series model in sunspec model definition (smdx) HOT 3
- Model 704 - Add VA_MAX_PCT to VarSetMod HOT 2
- Using model from id range 64900 as a placeholder to keep adresses stable HOT 2
- 712 Watt-VAr: Open loop response time is missing? HOT 2
- Order of Reactive Power Reference Enumerations HOT 1
- Model 714 is missing units
- Model 714, Point Tmp is missing scale factor
- Models 705, 706, 707, 708 - Update VRefPct unit label to VNomPct to clarify usage
- Clarification on SunSpec modbus error-handling
- 303 TmpBOM Scalefactor: -1 HOT 3
- Inconsistencies between JSON and SMDX models HOT 9
- Add static field to model 715 for ID and L points.
- Suggestion: Add sunspec version point to common model
- [Model 64020] Json swaps ProbeTmp and MainTmp fields compared to XML HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from models.