Git Product home page Git Product logo

Comments (7)

suncat2000 avatar suncat2000 commented on July 23, 2024

Hi
Large changes in the code were not added. Currently I haven't a time to check out. I Will check in a few days.
You can identify the problem or write a test?

from mobiledetectbundle.

williamMarx avatar williamMarx commented on July 23, 2024

Thanks. I am working on finding the problem. RequestListenerTest returns OK.

from mobiledetectbundle.

williamMarx avatar williamMarx commented on July 23, 2024

Hi Nick,

Here's an update after a few hours of digging around in the code:

I went through each bundle file and reverted each updated section of code to what it was when I installed the dev-master on January 4 and tested the result, one by one. Redirection still failed, every time. Interestingly, the device_view cookie was correctly set--mobile when tested with smartphone, not_mobile when tested with laptop--so basic detection worked, just not redirection. Again, no errors thrown. The only change I didn't test was the switch from yaml to xml config files, leading me to think something in this new code was causing my problem.

To test this possibility, I replaced v0.9.1 with v0.9.0, which still uses the yaml config. And sure enough, detection AND redirection work perfectly again! I don't know enough about using xml configs to locate the exact problem, but hopefully this information helps narrow down the possibilities, assuming anyone else can replicate my issue.

Thanks for your help--this is an incredibly useful bundle.
Will

from mobiledetectbundle.

ricoli avatar ricoli commented on July 23, 2024

Hi! this could have been because of #46

from mobiledetectbundle.

suncat2000 avatar suncat2000 commented on July 23, 2024

@williamMarx please update version and retest.

from mobiledetectbundle.

williamMarx avatar williamMarx commented on July 23, 2024

Works perfectly now, thank you!

from mobiledetectbundle.

suncat2000 avatar suncat2000 commented on July 23, 2024

Thanx @ricoli )

from mobiledetectbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.