Git Product home page Git Product logo

Comments (4)

sumiya11 avatar sumiya11 commented on September 26, 2024 1

Thanks for reporting that. I'll switch to pointers.

Also, IMO, using assembly at all, let alone so much of it, is a red flag/strong code smell for such a high-level package.

I'm not excited about this as well. ATM I just try to keep llvmcalls in a single file, and maybe I ought to rethink their usefulness later.

from groebner.jl.

sumiya11 avatar sumiya11 commented on September 26, 2024

UPD: Now there is one more file where llvmcallss are used: https://github.com/sumiya11/Groebner.jl/blob/1966672ac52cba9f68f90685433abd21f4e584cc/src/utils/packed.jl

These llvmcalls grant around 15% performance improvement on one class of inputs.

Either compilers become smart enough to produce such code by themselves or I decide I do not care enough and delete all llvmcalls -- whivever comes first.

from groebner.jl.

sumiya11 avatar sumiya11 commented on September 26, 2024

To be more precise

using Groebner, AbstractAlgebra
k = GF(2^30+3)
C = [
           Groebner.Examples.HIV2(k=k),
           Groebner.Examples.Goodwin_with_weights(k=k),
           Groebner.Examples.yang1(k=k),
           Groebner.Examples.Cholera(k=k),
           Groebner.Examples.bayes148(k=k),
           Groebner.Examples.mayr42(k=k)
       ];

@time for c in C groebner(c); end

No llvmcalls :

98.660280 seconds (121.74 M allocations: 12.032 GiB, 4.05% gc time)

With llvmcalls :

92.756787 seconds (121.74 M allocations: 12.032 GiB, 4.25% gc time)

This is Julia Version 1.12.0-DEV.1076

from groebner.jl.

sumiya11 avatar sumiya11 commented on September 26, 2024

Either compilers become smart enough to produce such code by themselves or I decide I do not care enough and delete all llvmcalls -- whivever comes first.

#157

from groebner.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.