This is currently done in two places right now. There's also too much data carried in

Consolidate input creation code about regal HOT 1 CLOSED

styrainc commented on May 25, 2024

Consolidate input creation code

from regal.

Comments (1)

anderseknert commented on May 25, 2024

Except for renaming the function (which I'll do in the next PR), I don't think there's anything more to do here. I tried rewriting the function to do the ast.InterfaceToValue transformation rather than have OPA do it, and pass input via rego.EvalParsedInput but interestingly, this turned out to be slightly slower than just passing raw input and have OPA do it. Some code here if we want to return to that some day, but for now it doesn't feel like it's worth pursuing.

// PrepareAST prepares the AST to be used as input for linting.
func PrepareAST(name string, content string, module *ast.Module) (*ast.Object, error) {
	value, err := ast.InterfaceToValue(module)
	if err != nil {
		return nil, fmt.Errorf("failed to read module as value: %w", err)
	}

	obj, ok := value.(ast.Object)
	if !ok {
		return nil, fmt.Errorf("expected module to be an objeect")
	}

	lines := strings.Split(strings.ReplaceAll(content, "\r\n", "\n"), "\n")
	linesTerms := make([]*ast.Term, len(lines))
	for i, line := range lines {
		linesTerms[i] = ast.StringTerm(line)
	}

	obj.Insert(ast.StringTerm("regal"),
		ast.ObjectTerm(ast.Item(ast.StringTerm("file"),
			ast.ObjectTerm(
				ast.Item(ast.StringTerm("name"), ast.StringTerm(name)),
				ast.Item(ast.StringTerm("lines"), ast.ArrayTerm(linesTerms...)),
			),
		)),
	)

	return &obj, nil
}