Better handling of CRLF about regal HOT 2 CLOSED

Thanks @asleire!

Thinking more about this, I think we could interecept the "will save document" event in the language server, and send back a notice (modal) to the client about disabling CRLF (or what have you) line endings if encountered in the document. We should only do that if the opa-fmt rule is enabled though, as otherwise we shouldn't interfer with whatever choices the user has made. What do you think?

As a side note — one way to avoid having editors mess with this is to use an .editorconfig file at the project root, specifically for Rego. We do this in Regal, although we share the same config for both Rego and Go (as they follow the same conventions in this regard): https://github.com/StyraInc/regal/blob/main/.editorconfig

I'm not sure VS Code uses this file without custom extensions, but GitHub and IntellJ certainly do.

from regal.

I think we could interecept the "will save document" event in the language server, and send back a notice (modal) to the client about disabling CRLF

That sounds great!

As a side note — one way to avoid having editors mess with this is to use an .editorconfig file at the project root, specifically for Rego

Yes, it shouldn't be difficult in most IDEs to use LF endings

from regal.