Comments (6)
Thanks for the quick turn around! If I see anything else I will let you know.
from regal.
Thanks @travbale 👍 Looks like you're right, and we should translate our "notice" level to "note" for SARIF. Any tooling that breaks because of this?
from regal.
SARIF Viewer for VsCode flags it as an error in the SARIF document.
from regal.
Thanks again @travbale 👍 PRs up for both issues. That the implicit-future-keywords
notice was included at all was a mistake of its own. There are essentially two types of notices at this point in time: 1) rules that have been excluded because some new capability or other rule made them obsolete and 2) rules that have been excluded because the targeted OPA version does not come with some more modern capability required by the rule.
Only the latter is interesting to most users, so that's the type we'll want to include in the reports (SARIF or not).
from regal.
Thanks @travbale! You could go build
from main once these PRs are merged if you'd want to test it with the known issues resolved before the next release (~2 weeks or so from now).
from regal.
Fixed with #516
from regal.
Related Issues (20)
- CI: See if we can use caching to avoid downloading rq over and over HOT 1
- Be specific about number of errors vs warnings in `regal lint` summary
- Rule: `if-object-literal` HOT 1
- Rule: `var-shadows-builtin`
- Not all folding ranges shown in Zed editor HOT 1
- Code completion in comments (Zed) HOT 2
- Zed doesn't render markdown tables
- Send message to client when outdated Regal is detected
- Completions: `if` and `contains` should not be suggested following import
- Completions: avoid suggesting recursive function call
- Completions: suggest known object keys for certain built-in functions
- Completions: provide suggestions of rules and functions in file following `default` keyword
- Allow using `regal fix` as a formatter
- POC: embedding compiler state for `regal lint` command
- Completion suggestions should not contain duplicates
- Suggest local variables as arguments to function call
- Improve package name suggestion based on directory path
- False positive in `top-level-iteration` when using ref head rules
- Completions: package name suggestion should never be an empty string
- Diagnostics reported remains after file is deleted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from regal.