Comments (12)
Dirty fix, improved:
Add
p, .js-vote-count, body, pre, code {
color: var(--highlight-color) !important;
}
pre, code {
background: var(--highlight-bg) !important;
}
and change the following
--highlight-bg: var(--black-200) !important;
--highlight-color: var(--fc-dark);
to
--highlight-bg: #181818 !important;
--highlight-color: #ddd !important;
from stackoverflow-dark.
Not a fix since this can't be done using user CSS, but using Greasemonkey or the like to add theme-dark
to the body
element's classes works remarkably well:
document.getElementsByTagName('body')[0].classList.add('theme-dark')
It works so well that some problematic areas like diffs in the revision history of posts appear better than before. (the actual colours might not be to your taste, but at least they're readable now).
from stackoverflow-dark.
As a quick fix I've inserted before line 67:
--theme-body-font-color: /*[[strong-color]]*/;
from stackoverflow-dark.
dirty fix
p, .js-vote-count, body {
color: #ddd !important;
}
from stackoverflow-dark.
I also want to mention that only stackoverflow is unaffected. Otherwise, yeah, the font color is black on every stackexchange network.
from stackoverflow-dark.
PR created. I've checked multiples SE sites, no more black text.
from stackoverflow-dark.
@SylwesterZarebski 's solution is already much better, but @muru 's solution also fixes the code blocks' background color!
Thank you both for your solutions!
from stackoverflow-dark.
@mpeter50 : Can You provide a link with wrong code blocks bg colours? I would check it.
from stackoverflow-dark.
Here is an example: https://superuser.com/questions/1613852/how-do-i-run-a-sudo-command-on-a-remote-machine-using-ssh
This is how it looks for me with your fix (no userscript, repo's userstyle edited by adding --theme-body-font-color: /*[[strong-color]]*/;
after line 66):
This is how it looks without editing the userstyle, but with the userscript:
from stackoverflow-dark.
@mpeter50 it looks like you're not using the StackOverflow Syntax Themes usercss. Check the README, it's "a required additional style".
from stackoverflow-dark.
Oh, thats right, thanks for pointing that out! I have now installed that style and this way its ok with this modification, without a userscript.
This way inline code blocks are less visually distinct than before, but after tweaking the settings of the syntax style a little its better then before! Just jotting it down in case anyone will find it useful.
from stackoverflow-dark.
Bug fixed by commit e53dd43
from stackoverflow-dark.
Related Issues (20)
- How to switch between themes? HOT 1
- (How) Should I report issues only present if "native" dark theme is selected? HOT 2
- Deprecated? HOT 2
- Unreadable logic keywords (or, and, ...) in custom filters HOT 2
- Syntax theme no longer work HOT 3
- Newsletter sign-up widget has duplicate header HOT 2
- Code parts barely readable HOT 2
- White code blocks on Stackexchange HOT 1
- Code blocks white or unreadable HOT 3
- Code span in comment has light text color HOT 3
- Code blocks are now white HOT 1
- unreadable text and missed implementation HOT 1
- Announcement bar is not dark-styled HOT 2
- SO updated CSS, <code> blocks now too low contrast HOT 4
- visited links in answers are shown dark HOT 3
- The background is bright everywhere HOT 1
- Add CSS "color-scheme: dark;" HOT 1
- Maintainers needed
- Font color is black HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stackoverflow-dark.