Configuration files part of firmware repo about esc-configurator HOT 3 CLOSED

Turns out this is a bit more tricky: Settings sometime require a function to determine if they are visible or not. This can not easily be abstracted into JSON. Obviously we don't want to blindly pull in stuff and execute functions since this could open doors for exploits.

from esc-configurator.

The visibility conditions are actually pretty trivial since they only reference fields in settings:

visibleIf: (settings) => settings.VARIABLE_PWM_FREQUENCY === 0,

could be abstracted in JSON of this form:

{
  field: 'VARIABLE_PWM_FREQUENCY',
  operator: 'equal',
  value: 0
}

depending on operator the value should hold different fields - the following options would cover all currently used visibleIf statements in AM32, BlHeli_S and Bluejay:

• equal: single value
• notEqual: single value
• oneOf: array of values

Obviously we would lose flexibility this way, but reduce maintanance of the Sources to basically zero, since they can be maintained in the repository itself.

Still leaves place for firmware maintainers to do something not intended and break functionality.

from esc-configurator.

There is a PR in preparation that aims at fetching the versions directly from the firmware repositories #147
ESC layouts were already moved to the repository itself, they are no longer fetched from 3rd party repositories.

This issue is thus pretty much obsolete.

from esc-configurator.