Enable rule `max-len` about eslint-config-stylelint HOT 11 CLOSED

I'm not a fan of max-len rules in linters, but I get your frustration.

I think we could split long if statements in value-keyword-case and other files.

Before:

if (node.type !== "word" || !isStandardSyntaxValue(node.value) || value.indexOf("#") !== -1 || ignoredCharacters.has(keyword) || getUnitFromValueNode(node)) {
  return
}

if (prop === "animation" && !keywordSets.animationShorthandKeywords.has(valueLowerCase) && !keywordSets.animationNameKeywords.has(valueLowerCase)) {
  return
}

After:

if (
	node.type !== "word" 
	|| !isStandardSyntaxValue(node.value) 
	|| value.indexOf("#") !== -1 
	|| ignoredCharacters.has(keyword) 
	|| getUnitFromValueNode(node)
) {
  return
}

if (
	prop === "animation" 
	&& !keywordSets.animationShorthandKeywords.has(valueLowerCase) 
	&& !keywordSets.animationNameKeywords.has(valueLowerCase)
) {
  return
}

Also value-keyword-case has this lines:

        if (expectation === "lower" && mapLowercaseKeywordsToCamelCase.has(keywordLowerCase)) {
          expectedKeyword = mapLowercaseKeywordsToCamelCase.get(keywordLowerCase)
        }

They are 95 and 81 characters long. max-len: 80 is too short.

from eslint-config-stylelint.

I think we could add more options:

"ignoreComments": true
"ignoreUrls": true
"ignoreStrings": true
"ignoreTemplateLiterals": true

We have long quoted lines in tests. And for messages.

from eslint-config-stylelint.

@hudochenkov sgtm to me for split long if statements, but good have lint errors or warnings to never forget it, the only solution I see setting rules on the length of the line.

from eslint-config-stylelint.

I'm indifferent to whether this is included or not.

You both make good points either way. Would max-len: 120 be an acceptable compromise?

It flags 192 warnings. It seems a lot of them are from conditionals in the rule code as exampled above, so it would be good at catching those:

if (node.type !== "word" || !isStandardSyntaxValue(node.value) || value.indexOf("#") !== -1 || ignoredCharacters.has(keyword) || getUnitFromValueNode(node)) {
  return
}

from eslint-config-stylelint.

@jeddy3 good for me

from eslint-config-stylelint.

max-len: 120 looks good for me.

It would throw a warning on a legit lines:

const isBlocklessAtRuleAfterSameNameBlocklessAtRule = require("../../utils/isBlocklessAtRuleAfterSameNameBlocklessAtRule")

This name 😂

But will help make the code more clear:

before = before[before.length - 1] === "*" || before[before.length - 1] === "_" ? before.slice(0, before.length - 1) : before

Source.

from eslint-config-stylelint.

@hudochenkov we can think about rename to more simple name or

const someLongLongLongLongVartiables 
  = require('some-long-module-name-more-than-120-characters-in-line')

from eslint-config-stylelint.

Or just add // eslint-disable-line max-len :)

from eslint-config-stylelint.

@davidtheclark Any objections to max-len: [2, 120]? If not, we can PR this before the next release of the config.

from eslint-config-stylelint.

I'm fine what whatever you all want.

from eslint-config-stylelint.

Done in #24

from eslint-config-stylelint.