Git Product home page Git Product logo

Comments (4)

ivanbanov avatar ivanbanov commented on May 24, 2024 2

hey @gregberge I just double checked the problem in an isolated repo to make sure there was nothing wrong, but it seems like the xstyled preset is not working properly.

I've tried the same example with emotion and also with xstyled, the emotion preset works well, but the same dummy example with xstyled still throws the Component selectors can only be used in conjunction with babel-plugin-emotion error

It can be checked in the gif (please click on it 😅)

I created a repo with the config that was used in the gif https://github.com/ivanbanov/xstyled-selector-bug, I really would like to help with a PR but Im not sure how to even debug it

from xstyled.

gregberge avatar gregberge commented on May 24, 2024

Storybook is doing weird things. It is complicated to make it work with it. The problem is not in xstyled itself. You have to trick the webpack config of storybook. I think you would have the problem with emotion also, try to find issue for making emotion + storybook working.

from xstyled.

ivanbanov avatar ivanbanov commented on May 24, 2024

@gregberge seems like there is another bug when using the <ThemeProvider /> with the xstyled preset, it always throws

Property name of JSXClosingElement expected node to be of a type ["JSXIdentifier","JSXMemberExpression","JSXNamespacedName"] but instead got "Identifier"

not sure, but this one seems to be related to this plugin babel-plugin-jsx-pragmatic 🤔

from xstyled.

gregberge avatar gregberge commented on May 24, 2024

v2 uses Emotion v11, so it is no longer relevant.

from xstyled.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.