Comments (10)
Hi,
we started to use it in our teams, and from my point of view the syntax is very clean. When you write styled-components you have to know that there is a theme that defines some keys or keywords. For me there is no possibility to misunderstand e.g. 'primary'.
I personally vote for leaving the syntax as it is.
I'll post an update when more devs will have their opinion on this topic.
from xstyled.
Yes it will not happen, if you want "$", then feel free to prefix all variables in your theme (you can also write an helper that prefixes all variables). It will not be part of xstyled core, but feel free to create your own convention.
from xstyled.
Actually, this should be a breaking change if accepted but I think it's worth it.
from xstyled.
Hello @sonhanguyen, I understand your point and your pros. But there is one thing very different from Sass, it is not a variable:
width: 0.123;
This value will be transformed into 12.3%
, it is confusing to have a $
in front of a value isn't it?
Maybe we could have the best of two world, being able to specify "$" or to not specify it. What do you think?
from xstyled.
I think one of the motivations is to reduce the chance of mistake. If we do introduce $ but also implicitly lookup when there is no $, it's gonna even increase the confusion and doesn't really prevent mistakes.
Per your point about the value conversion, I'm not aware it's a feature and I like to think about it as a separate thing from themed value lookup. So yes a plain number should just be width: 0.123
but a variable lookup should be width: $large
.
I'm not a fan of functional css approaches like styled-system
so I rely a lot on themed values, that's where your library could really help, since it makes heavy use of themed values less noisy. However, the ambiguity is really holding me back, to be honest.
from xstyled.
It can be a global option that once turned on you have to lookup with $ everywhere. So either use $ or not use $, no mixing. That could work 😄
from xstyled.
I will think about it, let's wait for community opinion.
from xstyled.
Same, at Smooth Code, we use it and it is not confusing. It depends of your theme values. Also you are able to specify $primary
in the theme. So it is up to you!
from xstyled.
Same, at Smooth Code, we use it and it is not confusing. It depends of your theme values. Also you are able to specify
$primary
in the theme. So it is up to you!
good point
from xstyled.
Great library, I would say no to making it an extra char like $
for variables. Xstyled is just shorthand extending SC/Emotion. When your writing theme/css your always referencing back to your theme so adding a $
doesn't add much value. What if you wanted to reference things down the theme tree - $primary['$var2']
doesn't really make sense when you could do primary.var2
.
from xstyled.
Related Issues (20)
- useUp & useDown accept number values but don't support them
- xstyled v 3.7.0 typescript error HOT 2
- Incorrect breakpoint with useBreakpoint hook HOT 3
- Why height and width are shortened? HOT 2
- TS error when trying to export xstyled with added utilities HOT 1
- Document site is broken on android chrome when revisited. HOT 1
- Rename the color prop to just c HOT 10
- `border` shorthand handling is buggy HOT 1
- Fractional keys in the theme are not working HOT 1
- Passing `as` prop while using styled notation creates hydration errors in NextJS dev mode HOT 1
- The Documentation should have examples in typescript and plain javascript. HOT 1
- the documentation page has unnecessary horizontal scroll HOT 1
- I'm getting an error using in SSR with NextJS: Attempted import error: 'useState' is not exported from 'react' (imported as 'React').
- Exist a way to generate the style object or classNames to be used in other third party libraries?
- Incompatibility with GatsbyJS? I have problems to make builds to production, the components are not seen with the style.
- Is it possible to style an element based on parent hover? HOT 1
- Are nested color objects in theme supported?
- Nextjs app dir?
- Is there an easier way to adding new utilities?
- Is there any way to remove color preset in colors property?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xstyled.