Git Product home page Git Product logo

Comments (4)

stuartmemo avatar stuartmemo commented on July 29, 2024

Hmm, their documentation is pretty useless. Method details on the page return 404s. Have filed a bug.

Do you think it's worth removing fadeIn/fadeOut just now? I'm thinking it would be worth make the code base a bit more solid on all browsers before doing fancy stuff like this.

from theresas-sound-world.

stuartmemo avatar stuartmemo commented on July 29, 2024

Saying that, I'm guessing we should handle that if it's easy to detect which parameter is which. We could just swap them around?

from theresas-sound-world.

JackCA avatar JackCA commented on July 29, 2024

We could detect the browser and swap the arguments... But for what it's worth, those two methods are undocumented and probably won't be used by someone who isn't digging through the source code. Removing them might be the better solution at the moment.

re: the documentation. You're right and without the source or the docs it's hard to tell what they're doing. The only way I can infer that the args are switched is because:

  1. The documentation on that main page discusses the arguments in reverse order
  2. Actually switching the arguments in the implementation appears to work... Or so it appears

from theresas-sound-world.

stuartmemo avatar stuartmemo commented on July 29, 2024

Cool, have removed them. #21

from theresas-sound-world.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.