Configuration files lost on web upgrade about nextcloud-spreedme HOT 12 CLOSED

replaces the whole app folder with it

Oh i see - then its not a bug - thanks for the explanation. Still we need to improve.

from nextcloud-spreedme.

#39 should make it easier to upgrade the app.

from nextcloud-spreedme.

Well, once you have migrated to the new way to configure the app (via web interface), you will never need to re-configure the app again.

1. Rename apps/spreedme/config/config.php to e.g. apps/spreedme/config/config-old.php
2. Open /index.php/settings/admin#goto-spreed.me in your browser
3. Click Generate new shared secret and copy the secret to your clipboard
4. Click Save settings
5. Head over to Spreed WebRTC’s config, and use the new secret for sharedsecret_secret
6. Restart Spreed WebRTC. You will never need to re-configure the app again.

from nextcloud-spreedme.

@leonklingele can we do something about this overwriting problem?

from nextcloud-spreedme.

@JSoko
Please see https://github.com/strukturag/nextcloud-spreedme#upgrading-this-app

@longsleep
We could store all settings from config.php in the NC database.
The settings of OwnCloudConfig.js however can't be stored in the database.
OwnCloudConfig.js currently is only needed to tell Spreed WebRTC where it can find the NC host. If we completely deprecate support for setting up NC/oC on two different hosts / NC/oC in a subpath, we can remove this file.

from nextcloud-spreedme.

@leonklingele
Thank You for the hint, but IMHO spreed.ME is the first app which does the upgrade from the store and needs to be configured again afterwards.

So if you wont go the way, you mentioned to @longsleep IMHO before doing the upgrade, the user should see an alert and the possibility to stop the update.

And there should be an updatediscription in the appstore too
https://apps.owncloud.com/content/show.php/Spreed.ME?content=174436

from nextcloud-spreedme.

@JSoko have you upgraded the app directly from the web interface or have you downloaded the upgrade manually (e.g. via App Store)?

from nextcloud-spreedme.

@leonklingele
directly from the web interface and had looked before in the appstore what has changed.

I didn't look in the installation guide before updating...

from nextcloud-spreedme.

We should try hard to avoid overwriting any user made configuration on update ttw. I also do not see why it actually would overwrite anything as the repository does contain OwnCloudConfig.js.in only and the user is supposed to have copied this. Whats wrong here?

from nextcloud-spreedme.

Well – If the app is upgraded via web interface, NC downloads the tarball of the new release from the oC app store and automatically replaces the whole app folder with it.

In nextcloud/server#880 nextcloud/server#880 we might find a solution for this issue.

from nextcloud-spreedme.

@leonklingele
Now I've done an update to 0.3.1 through the webinterface.

after that, it shows that spreed.me isn't configured

You have to copy and modify config.php in /apps/spreedme/config again...

After that, it works again. The javascript config file now don't have to be touched :-)

Than, In the admin-panel under nc 9.53 it shows:

Spreed.ME
config/config.php was found.
If you want to change it, you need to edit the file by yourself.
extra/static/config/OwnCloudConfig.js was not found.
If you want to run Spreed WebRTC and Nextcloud on different origins, please read this document.

IMHO OwnCloudConfig.js was not found could be read as an erro and should be clarified...

from nextcloud-spreedme.

Yes, now i've seen it...

great work!

from nextcloud-spreedme.