Comments (4)
No, that just hides errors and there is no reason to save this one bit. If some computation gives negative values, errors are obvious. If you use unsigned, they overflow and are more difficult to find.
from libde265.
I am surprised that you do not like unsigned integers here. I would prefer their use at various places to make the software a bit safer by design.
from libde265.
Feel free to do so.
And then have fun with code like
for (uint32_t i=length-1;i>=0;i--) { ... }
2013/9/6 Markus Elfring [email protected]
I am surprised that you do not like unsigned integers here. I would prefer
their use at various places to make the software a bit safer by design.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-23928788
.
from libde265.
for (uint32_t i = length - 1; i >= 0; --i) { ... }
Would you like to point out that the data types "uint32_t" and "size_t" have got different value ranges eventually?
from libde265.
Related Issues (20)
- heap-buffer-overflow `libde265/libde265/motion.cc:1719` in `derive_spatial_luma_vector_prediction` HOT 2
- heap-buffer-overflow `libde265/libde265/motion.cc:1443` in `derive_combined_bipredictive_merging_candidates` HOT 3
- heap-buffer-overflow `libde265/libde265/motion.cc:1860` in `derive_spatial_luma_vector_prediction` HOT 3
- Bug in `de265_image::alloc_image(…)` ? HOT 1
- Fix private libraries in libde265.pc for autoconf / automake build
- Switch to cmake and remove autoconf/automake HOT 3
- Heap-buffer-overflow with ASAN in dec265
- `bjoentegaard` freezing if invalid parameters has been supplied
- cmake does not compile neon code for arm architecture HOT 1
- Add sps_multilayer_extension support MV-HEVC Multiview HEVC HOT 1
- Encoder sample crash
- Error compiling in Visual Studio 2022. Missed #include: <cstdio> and <cstring> in sdl.cc?
- Adapting H.265 Video Compression for 16-Bit Integer images
- pkg-config file Libs.private needs fixing HOT 10
- sherlock265 missing last two frames HOT 1
- Feature Request: GStreamer libde265 encoder with enc265
- HELP~, dec265 decode my h265 file failed HOT 1
- Compile issue on Linux when running 'make' under sherlock265: No such file QtGui and qglobal.h HOT 1
- Heap-buffer-overflow with ASAN in dec265
- Should the destructor of decoder_context include more cleanups?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libde265.