Spring Pet Clinic demo doesn't have public controllers about java HOT 9 CLOSED

That's now done.

from java.

Is this with a "git checkout 95de1d9f8bf63560915331664b27a4a75ce1f1f6"?

from java.

In spring-projects/spring-petclinic@95de1d9 (2016-01-30) as you ask for example PetController is public. The change I am writing about happened on (2016-11-10), wich is later than the version you asked for.

from java.

I'm not sure that I understand what you're asking for. Does the PetClinic tutorial work as instructed?

from java.

No it doesn't work for me.

I am able to upload all diagrams exactly as expected except for component diagram, which is missing all Controllers. I looked at the javadoc for SpringComponentFinderStrategy and found out, that it ignores all non-public classes. I looked into PetClinic source (which I checked out today - fresh master) and all controller were declared package-private (no modifier).

I say: Tutorial is missing either:

• notice in tutorial, that it works only on commits before spring-projects/spring-petclinic@83ff9a5
• or a line of code, using springComponentFinderStrategy.setIncludePublicTypesOnly(false); which is what I ended up with.

from java.

Understood. The instructions for cloning the PetClinic repo do include a specific revision though -> https://github.com/structurizr/java/blob/master/docs/spring-petclinic.md#1-clone-and-build-the-spring-petclinic-code

from java.

Oh! My bad. I followed the link to PetClinic repo and basically skipped the rest of the code area, with "I know how to checkout" in my mind.

from java.

No problem! I'll add a note to explain why the checkout is needed. :-)

from java.

OK, for me that fixes the problem.

from java.