AbstractReflectionsComponentFinderStrategy only allows for dependencies in the scanned package about java HOT 6 CLOSED

If you create a ComponentFinder for the third-party components first (and call findComponents), and then create a second ComponentFinder for your own components, you should see the relationships show up.

from java.

ok, added the component manually to the container, before adding the
component finder for spring, so instead of doing this, i have to add a
component finder that "finds",(or just adds ) the 3rd party components.
Thanx

On Thu, Mar 31, 2016 at 10:38 AM, Simon Brown [email protected]
wrote:

If you create a ComponentFinder for the third-party components first (and
call findComponents), and then create a second ComponentFinder for your own
components, you should see the relationships show up.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#25 (comment)

from java.

it only works when i do it the other way around,

So first i define scan my own components, then i add the 3rd party finder, and probably only because i don't extend the AbstractReflectionsComponentFinderStrategy for the 3rd party component Finder.
`

ComponentFinder axonComponentFinder = new ComponentFinder(
    containers.webApplication, "org.axon",
    new AbstractNamingConventionComponentFinderStrategy() {
        @Override
        protected boolean matches(Class<?> type) {
            return type.equals(DefaultCommandGateway)
        }
    }
);


ComponentFinder componentFinder = new ComponentFinder(
    containers.webApplication, "nl.devnoo",
    new CustomComponentFinderStrategy()
);

componentFinder.findComponents();
axonComponentFinder.findComponents()

`

if i change the order of the find components it won't put the dependencies.
Seeing the code in the AbstractReflectionsComponentFinderStrategy this seems logical, because it gets the components from the container and then intentionally excludes the components that are no in the current package to scan.

from java.

I'm been mulling this over and the following check in findEfferentDependencies seems unnecessary, especially if previous component finders have found components in different packages.

if (referencedTypeName.startsWith(componentFinder.getPackageToScan())) {

I'll create some test cases to simulate what you're doing.

from java.

That restriction has now been removed; you should be able to use multiple component finders in any order. Thanks Job.

from java.

Yeah was exactly the if statement i was wondering about. Thanks for the
quick reaction.

On Thu, Mar 31, 2016 at 10:57 PM, Simon Brown [email protected]
wrote:

That restriction has now been removed; you should be able to use multiple
component finders in any order. Thanks Job.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#25 (comment)

from java.