Test case settings/invalid data: Lexer reads freed memory; Causes crash about strongswan HOT 9 CLOSED

It might not be entirely safe to use yytext (settings_parser_get_text in our case) in yyerror (settings_parser_error), especially in those test cases. But this doesn't seem like that much of an issue (anything but valgrind won't notice) and for some errors it could give the user a clearer indication what's wrong in the config file, so I'd rather keep it in.

from strongswan.

from strongswan.

So that's musl output? Not from valgrind? And where does it crash? (Seems to continue running after the first reports.)

from strongswan.

No, that's valgrind output, but I checked what exactly happened with valgrind. I can get you a complete coredump when it crashes in the test with all binaries involved, if you want.

EDIT: Also the log messages of valgrind might or might not be synchronized with the output of the binary that is run using valgrind.

from strongswan.

So which test cases crashes exactly?

from strongswan.

Running case 'valid/invalid data': +-
Failure in 'test_invalid': SIGSEGV(11) (i = 0)

from strongswan.

OK, yeah, when I run this test with TESTS_VERBOSITY=1 I see this:

syntax error, unexpected $end, expecting NAME or NEWLINE or '}' [�]

That's for this input

unterminated {
  not = valid

Since it reaches EOF, there is not really any incorrect text to report, so yytext and yyleng are not properly defined (the latter is still 1 even though the former points wherever). Unfortunately, it doesn't seem possible to distinguish between this case and others where the output could make sense (e.g. for spaces in name {}, where the error message is syntax error, unexpected NAME, expecting : or '{' or '=' [in] and [in] helps to identify where the problem is). So I guess we can't avoid removing that text output. I pushed that to the 346-parser-error branch. Let me know if it works for you.

from strongswan.

Thanks, with the patch it doesn't crash at the test anymore.

from strongswan.

Thanks for testing, applied to master.

from strongswan.