Git Product home page Git Product logo

Comments (3)

Aystub avatar Aystub commented on May 30, 2024

So the issue I had was that if you initialize a card using that constructor, it'stype is set to null. card.validateNumber() checks the card's type against defined lengths (15 in the case of Amex). If you have no type, it assumes you want the standard card length (16 for Visa's, Mastercard, and Discover). So in your example, it would most likely work if you called card.setNumber("4242 4242 4242 4242") because it's a Visa with the length it's looking for. There is no setter for type, type is private so you cannot directly mutate it, getType() just on the fly returns a type but never sets anything, so the only option is to create a new Card and manually set the type to card.getType() once you know you have enough info for it to compute what the type actually is. Then validateNumber() should return the correct result.

from stripe-android.

agentcoops avatar agentcoops commented on May 30, 2024

Hi, @Numan1617, thanks again for reporting this issue! I just wanted to note that your PR at #34 has been merged---did that resolved the problem for you?

from stripe-android.

mrmcduff-stripe avatar mrmcduff-stripe commented on May 30, 2024

Looks like this has been resolved -- if you're still experiencing this problem, feel free to reopen!

from stripe-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.