Dependency on Android Framework breaks our unit tests about stripe-android HOT 6 CLOSED

If you prefer to keep that change out, you can roll the change back in your code by using
compile 'com.stripe:stripe-android:1.0.5', which is the version before any of the changes took place.

Since I don't otherwise use TextUtils, I could use something else in a future update for this check, but use of the android framework is probably going to creep into new features at some point.

from stripe-android.

Since you can fix the broken tests using a quick gradle change, I'm going to go ahead and close this issue. Let me know if rolling back the version in your code doesn't work!

from stripe-android.

We use Stripe 1.0.6 now and it works (it has no Android framework dependency yet) but we obviously want to get new features/fixes in future Stripe releases. So dependency on Android framework makes our Android-independent Unit testing of payment logic impossible.

I think you should avoid Android-framework dependency as wide as you can to allow developers to use the library in Unit tests. As I see it's possible for now, just need to rollback boolean isWholePositiveNumber(String value) method.

I wonder if it's gonna happen and should I looking forward for 1.1.1 soon?

from stripe-android.

Are you trying to share code between an android and a java application? I'm a little confused as to why you'd want to write an Android app without the Android framework.

from stripe-android.

It's not a big deal for me to move it out of that method - I added it by habit more than anything else. But I hadn't planned to make a concerted effort to keep core android classes out of future updates to our android API. There are future plans down the line to do things like having the simple checkout forms, similar to what exists in the stripe-ios SDK, and creating overlay forms is something I'd definitely use many core classes for.

from stripe-android.

I'll go ahead and take this out for now -- but I'm doubtful on my ability to keep the android framework out of the API indefinitely.

from stripe-android.