Comments (4)
brandur
commented on September 13, 2024
Hi @jleclanche,
So I have to admit that I don't have the benefit of knowing the history of this decision, but these are actually two different enums, and for maximum correctness, they should be treated as such.
card_brand under review is actually a brand abbreviation like amex or dscvr. See here for details.
brand under source is a complete brand name like American Express or Discover. See here for details.
from openapi.
jleclanche
commented on September 13, 2024
Any chance these could be considered for consolidation? Its a minor issue
but a paper cut nonetheless.
…On Mon, Apr 2, 2018, 23:05 Brandur ***@***.***> wrote:
Hi @jleclanche <https://github.com/jleclanche>,
So I have to admit that I don't have the benefit of knowing the history of
this decision, but these are actually two different enums, and for maximum
correctness, they should be treated as such.
card_brand under review is actually a brand abbreviation like amex or
dscvr. See here for details
<https://stripe.com/docs/radar/rules/reference#supported-attributes>.
brand under source is a complete brand name like American Express or
Discover. See here for details
<https://stripe.com/docs/api/java#card_object-brand>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAOXkuP1xNiRWIAVpAIZp8ZmWeQCqBr6ks5tkpKwgaJpZM4TCV-N>
.
from openapi.
brandur
commented on September 13, 2024
I opened an issue with the team that owns these APIs. Unfortunately, I wouldn't have hugely high hopes given that this would be a backwards-incompatible change and a non-trivial amount of work to be implemented, but I'll let you know if they get back to me with anything.
from openapi.
richardm-stripe
commented on September 13, 2024
Hello @jleclanche, I am closing this issue. I don't think unifying these properties is something we are going to pursue.
from openapi.
Related Issues (20)
- `POST /v1/ephemeral_keys` is missing the `verification_session` property HOT 2
- Add support for the new Tax Calculations HOT 1
- Chitwad
- Add license to info block
- BETA Money Movement APIs HOT 1
- Missing BETA issuing APIs HOT 1
- POST /v1/subscriptions missing a required parameter? HOT 8
- GET /v1/terminal/readers missing preview param `serial_number` HOT 4
- recursion between file and file_link HOT 2
- Plan in subscription object HOT 1
- Additional OpenAPI field properties: title and readOnly HOT 7
- Automatic pulling latest spec3.json per new Stripe OpenAPI release? HOT 2
- miss error invalid_bank_account_iban\invalid_owner_name HOT 5
- Frontier Climate: a bug report HOT 1
- `refunds` on `charge` is marked as required, but is not included in all requests HOT 3
- Update to Documentation HOT 1
- Retrieve events by related_object=<customer id> HOT 2
- Order Return Object has Disappeared HOT 2
- Question about subscription item quantity set to 0 HOT 1
- Spec3.json with Swagger UI - Out of Memory error HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapi.