Subtitles Handler not being called? about stremio-addon-sdk HOT 9 CLOSED

The issue is fixed in staging. After a couple of hours it will be available to all users.

Bare in mind that the subtitles resource is identified by OpenSubtitles hash and not IMDB ID, so global idPrefixes in your manifest would not match any subtitles.

If your add-on provides only subtitles I suggest you to remove the idPrefixes property from your manifest.

from stremio-addon-sdk.

@DeadalusVIII we've decided we're making some changes to the way subtitles are requested, that will be rolled out on monday:

https://github.com/Stremio/stremio-addon-sdk/releases/tag/v1.1.4
https://github.com/Stremio/stremio-addon-sdk/blob/v1.1.4/docs/api/requests/defineSubtitlesHandler.md

we've exchanged the place of the opensubtitles hash and the videoId, to make the request consistent with other add-on system requests

from stremio-addon-sdk.

This is an issue in Stremio. It looks like only the first add-on, that provides subtitles is called.
Expect a fix to be rolled soon.
Meanwhile you can test your add-on by disabling all other subtitles related add-ons, namely the Open subtitles one.

You can find the subtitles related documentation here.

from stremio-addon-sdk.

Ah, too bad. I'll try that, then. Thanks for the quick response.

from stremio-addon-sdk.

Makes sense. Thank you for the heads-up!

from stremio-addon-sdk.

Hi there! Was this ever actually fixed? My subtitles handler never gets called.

You can even check in the default code that's generated with the addon bootstrap cli. Even there, the subtitles handler is not called. Even after uninstalling all subtitle-providing addons as mentioned above, it still does not get called.

from stremio-addon-sdk.

from stremio-addon-sdk.

@Ivshti Thanks for the quick response. I'm testing the add-on via the web staging app (staging.strem.io). In any case, it doesn't work on my installed stremio client either, which is on v4.4.25. What settings would you need to see?

EDIT: Interestingly enough, i uninstalled and installed the add-on again and now it is being called. Worked fine for a bit, then again it didn't seem to be getting called. This time, though, I just backed out of the stream and clicked it again and for whatever reason it worked again.

from stremio-addon-sdk.

@pedroslopez
there was a new release made y-day, it should fix the subtitle issues you've been having

from stremio-addon-sdk.