Private clients hardcode schemas path at compile time about avrora HOT 6 CLOSED

👋🏼 @LostKobrakai Thanks a lot for your effort, I will take a look and let's discuss what we can do about it in this issue 👍🏼

from avrora.

Ok, I can confirm that I see the issue with umbrella releases and 2 different clients root dirs. Let me read a bit about umbrella releases

from avrora.

After a few modifications of the issue reproduction repo, I would like to propose the same way as Ecto is doing it.

defmodule ReproB.Client do
  use Avrora.Client,
    otp_app: :repro_b,
    schemas_path: "./priv/schemas"
end

An :otp_app option will be for the private client only, since a shared client can't be used with more than 1 app. I've tested and it seems working fine.

Does it make sense to you? WDYT?

from avrora.

The umbrella part here should really be irrelevant. The important bit is that Application.app_dir at compile time will point at _build/…, which will neither be available to releases once moved to another machine, nor when the application is used as a dependency in another project. Plain relative paths do not work given mix and releases use different folder structures.

The solution will involve running Application.app_dir at runtime instead of compile time in some form. How we supply the inputs for that doesn't really matter to me.

from avrora.

Yeah, I get it. It actually still relevant for both Avrora and its private clients. I will push proposed configuration this week 🗓️

from avrora.

Heads up @LostKobrakai, I would like to say thanks for your great support, it was very helpful to have an example app. A new configuration option was added to the private client and shared client – otp_app, which will be used to resolve the path to the schemas in a runtime. Thanks 🎉 🍾

from avrora.