Comments (2)
A send only chan communicates the intent better, but makes it impossible to return the user supplied parameter in this API as it's not possible to cast directional channels to the other side. The idea with returning the caller's param is to make it clear at the call site that the chan is only valid when having registered with NotifyReturn and reduce one intermediate variable.
go processReturn(channel.NotifyReturn(make(chan Return, 1)))
Alternatively, accepting a send only channel does make the intent clearer, though the code longer with even more stutter var string_ string = strings.NewString()
.
returns := make(chan Return, 1)
channel.NotifyReturn(returns)
go processReturn(returns)
For strictness sake, removing the return value and accepting a directional channel could be better but I'm not certain how much value that'd give as the call-site would need a bidirectional channel to be useful.
Do you have a concrete example where an API with a directional channel would resolve an ambiguous usage for the caller?
from amqp.
Feel free to reopen if you have a compelling case on the call site to change the API.
from amqp.
Related Issues (20)
- AMQPLAIN authentication does not work
- incorrect bindings in management UI
- Why use struct instead of pointer? HOT 1
- Channel blocks despite connection is closed HOT 5
- Adding a note that this repo has moved to github.com/rabbitmq/amqp091-go
- failed to dail() when password contains with special characters like "#"
- TestTLSHandshake failing with Go 1.18 due to denial of SHA1 certificates HOT 1
- How to get one message from queue
- consume stops receiving messages after reconnecting HOT 1
- RabbitMQ has open connections(Too many File descriptors piling up on broker) for publish HOT 1
- Documentation contradiction in regards to flow
- When I consume from a queue, the queue goes up HOT 3
- Coverity Scan - Identical code for different branches
- How do I use a proxy server to connect?
- tls problem
- Tagging
- Error sending to queue
- channel.Confirm hangs
- Error consuming from a queue that contains data packaged with msgpack
- if the Conn:Channel ratio is not 1:1 please help me understand API HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amqp.