Property variable_values from class Info returning wrong information about strawberry HOT 12 OPEN

@ShtykovaAA you can do that using UNSET: https://play.strawberry.rocks/?gist=a70bc1aa74d5d04a6ceea1be6a7b7575

https://strawberry.rocks/docs/types/input-types#defining-input-types

from strawberry.

@patrick91 it works! thank you!

from strawberry.

@patrick91 sorry I checked that it doesn't work for @strawberry.experimental.pydantic.input(PydanticModel) and I want to fix it, do I need another conversation?

from strawberry.

@ShtykovaAA cab you make an example in the playground? I think pydantic should work there ☺️

from strawberry.

@patrick91 yes! here an example https://play.strawberry.rocks/?gist=fdff10f784dd786a67d2e74bbab95d77

from strawberry.

@patrick91 I found the place of mistake: https://github.com/graphql-python/graphql-core/blob/main/src/graphql/utilities/coerce_input_value.py#L102
So if I'm using strawberry.input the default value is Undefined, but than I'm using @strawberry.experimental.pydantic.input(PydanticModel) the default value is None...

from strawberry.

@ShtykovaAA thanks for checking! I might have some time to fix this during the weekend, or feel free to send a PR if you find a way to fix it!

from strawberry.

@patrick91 I'm newbie but I really want to take a chance

I think we need to check this condition https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/experimental/pydantic/object_type.py#L76 because it means that we are overwriting our strawberry.input by PydanticField and that's why the default value is None, but not UNSET.

what do you think about it? I think it's a big change in project, but I think that it's supposed to be like that

from strawberry.

@ShtykovaAA I'm not too sure! Feel free to try and send a draft PR, we should have enough test to make sure this becomes a valid change 😊

from strawberry.