Refactor Select / Combobox about design-system HOT 6 CLOSED

Btw, this refactor has lead to breaking changes in multiple Strapi plugins. Very frustrating to debug also, the documentation is very light on detail.

from design-system.

@julesrenaud Can you please describe the issues you are facing with reproducible steps? It would be best if you can open separate issues for each problem - otherwise it is almost impossible for us to fix these problems.

from design-system.

@gu-stav what I've stumbled upon thus far is that the clear button used to be present and usable automatically, now the onClear attribute needs to be specified. Also, it's now impossible to have a list that has autocomplete === none. If a value is selected, upon opening the combobox, only the selected value is shown as an option. Autocomplete should be a usable option, because in the past it was possible to manage the shown options programmatically.

from design-system.

@gu-stav I think a very simple fix would be to add a autocomplete prop to be able to use 'none', as outlined as an example here: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-autocomplete-none/

from design-system.

@gu-stav I think a very simple fix would be to add a autocomplete prop to be able to use 'none', as outlined as an example here: w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-autocomplete-none

it's not a simple fix because i believe if you set autocomplete === "none" then you need to start visually focussing items in the list, however, this addition has been added in #985 and is hopefully going to be released in the next two weeks.

I've stumbled upon thus far is that the clear button used to be present and usable automatically, now the onClear attribute needs to be specified

You're welcome to submit a PR to fix this 👍🏼

from design-system.

@joshuaellis thank you for your response. I don't know how the Combobox component was designed/working before, all I know is that custom field plugins that were based on it stopped working after a minor upgrade of Strapi, which is obviously a problem. I'm sure y'all are making the design system better through these upgrades, just a heads up though that these components are used externally and that breaking changes without notice in minor upgrades should be avoided.

Personally I'll just adapt my plugins to the changes that were made. I'm using a fork in production for the autocomplete === none feature in the meantime.

from design-system.