Git Product home page Git Product logo

Comments (4)

shilman avatar shilman commented on May 28, 2024

AFAIK the maxWorkers determines how many pages get created. these pages get reused throughout the lifetime of the test run, unless there is a failing test. at that point, the page gets reset. How many workers are you using?

from test-runner.

IanVS avatar IanVS commented on May 28, 2024

Github runners have two cores, so two I guess two workers.

these pages get reused throughout the lifetime of the test run

Are you sure about that? I see output like this, which makes me think that each story needs to load a new page

page loaded in 782ms.
PASS browser: chromium src/components/patterns/snippet/Snippet.stories.tsx
page loaded in 798ms.
PASS browser: chromium src/components/atoms/forms/textarea/Textarea.stories.tsx
page loaded in 788ms.
PASS browser: chromium src/components/atoms/buttons/inline-button/InlineButton.stories.tsx
page loaded in 787ms.
PASS browser: chromium src/components/patterns/page-header/PageHeader.stories.tsx
page loaded in 768ms.
PASS browser: chromium src/components/atoms/forms/label/Label.stories.tsx

from test-runner.

shilman avatar shilman commented on May 28, 2024

Hmm can confirm that it opens a new browser for each story file. @yannbf this sounds like a bug to me. WDYT?

from test-runner.

IanVS avatar IanVS commented on May 28, 2024

I think this might just be the way that the jest runner for playwright works. I believe a new page is loaded each time using https://playwright.dev/docs/api/class-page#page-goto. I've opened playwright-community/jest-playwright#791 asking if perhaps there's a way to avoid that full page load each time.

from test-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.