[Bug]: Playwright version needed changes without dependency versions having changed about test-runner HOT 5 CLOSED

Hey there @sw-tracker, thanks for reporting this issue.

As you can see, the test-runner has a dependency range for Playwright that's quite low, ^1.14.0. It should conform with whatever you have installed in your lock file. You're the first person to report this kind of issue, and I'm not sure how to reproduce it easily (a repro would be appreciated!). I also don't know if this is the behavior related to the test-runner's execution of Playwright, or if it's from Playwright itself (like if it would happen when not using test-runner, but just Playwright directly).

Could you maybe do a bit more investigation on your side? Thanks!

from test-runner.

Thank you! You found the problem!

If you add ^ to a dependency (which in my opinion you should not do), this will allow the dependency to be updated to minor and patch updates.

We have seen playwright updates due to storybook like this: 1.32.3/1.41.2/1.42.1/1.43.1 and now the dependency is [email protected] due to @storybook/[email protected] after executing npm ls --depth=2 on my project.

Playwright happens to change browser versions when it updates its version, even minor version updates. This means we have to install new versions of the browsers every time this happens due to your dependencies. We also use playwright for E2E testing, and we never have this problem with that dependency. In our projects we want to have reproducible builds as close as possible, which means we lock our dependency versions (which I think everyone should do).

Could you please lock your playwright dependency? (remove the ^)

from test-runner.

I would also recommend that you create an .npmrc file and add save-exact = true to it. This will save you a lot of headaches in the future.

from test-runner.

Hi there, we have locked the playwright version on our package.json. Thank you!

from test-runner.

Could you please lock your playwright dependency? (remove the ^)
@sw-tracker unfortunately that would mean that anyone using the test-runner would have to install a specific version of playwright. The test-runner aims to be flexible so that you can use whatever version of playwright you'd like. Regarding which version you end up using, it's up to you, to how you manage your lock files and dedupe your dependencies. You can always use resolutions/overrides to make sure you get a specific version in your project though!

from test-runner.