Git Product home page Git Product logo

Comments (5)

THETCR avatar THETCR commented on June 12, 2024 3

@chrisburkejr
This fix was incorporated with f073b57.
Which only took more then half a year and the issues were just blatantly ignored.

The difference in size of the installed production dependencies is 18,2 MB.
In the past year this package was downloaded 94.5 million times.
That is approximately 1639 TB of wasted data.

from mdx1-csf.

chrisburkejr avatar chrisburkejr commented on June 12, 2024 2

Can this get approved and merged? This looks like a super simple change and is effecting users who are using nx storybook generators.. @aschlumpf is correct there is no solid workaround

from mdx1-csf.

THETCR avatar THETCR commented on June 12, 2024

The same thing applies to prettier, ts-dedent and @babel/preset-env.
ts-dedent and @babel/preset-env are listed as dependencies and devDependencies

Looking at the package manifest it seems a lot of dependencies are heavily outdated and some of them are not even used.

from mdx1-csf.

aschlumpf avatar aschlumpf commented on June 12, 2024

This causes projects which use lodash to have many type errors, and there is no solid workaround other than removing the @types package manually in a post-install script for npm/yarn. See microsoft/TypeScript#18588. This blocks my project from upgrading our storybook version.

from mdx1-csf.

chrisburkejr avatar chrisburkejr commented on June 12, 2024

@THETCR Thanks for pointing this out, this actually is enough to unblock by putting this in peer deps. Sorry about the wasted downloaded data for dependencies..

from mdx1-csf.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.