Comments (5)
This would be awesome! Currently Story blocks only get recognized under Preview blocks specifically, so we’d need to fix that for that part of your proposal to work. But having a Figma block would be amazing. How quickly could you turn that around? I want to do a post promoting DocBlocks as part of the 6.0 release, and would love to include that.
from addon-designs.
Currently Story blocks only get recognized under Preview blocks specifically, so we’d need to fix that for that part of your proposal to work.
I think it's not such problematic, just designing Blocks to keep <Preview><Story>
structure would be enough IMO.
// something like this?
<WithDesign figma="https://www.figma.com/file/Klm6pxIZSaJFiOMX5FpTul9F/storybook-addon-designs-sample">
<Preview>
<Story>
<Button>Button</Button>
</Story>
</Preview>
</WithDesign>
If everything goes well, especially the theming and styling stuff, I can release (alpha, beta, or stable IDK) this feature within a week.
from addon-designs.
No. Story needs to be either at the top level or directly below Preview at the top level. It’s kind of an arbitrary requirement... nothing fundamental. But would require a chance to Storybook to support your proposal. Maybe start with the Figma and other standalone blocks and do the composite ones in SB 6.1?
from addon-designs.
If you just want to annotate Story
with design info you can use parameters:
<Story name=“foo” parameters={{ design: { ... }}}>...</Story>
from addon-designs.
No. Story needs to be either at the top level or directly below Preview at the top level. It’s kind of an arbitrary requirement... nothing fundamental. But would require a chance to Storybook to support your proposal. Maybe start with the Figma and other standalone blocks and do the composite ones in SB 6.1?
Oh... so is it better to ship only embed components (e.g. <Figma>
, <Pdf>
) and defer the tabbed-preview feature? TBH, the tabbed-preview feature is just an early idea and I'm not sure whether that is needed... Supporting non-top-level <Preview>
sounds good but it will bring complexity in story parsing, so discussing carefully after a user submits a feature request is okay and keeps things simple 👍
from addon-designs.
Related Issues (20)
- Figma login error HOT 4
- Unable to install beta v2 after installing Storybook v7-beta63 HOT 6
- Dependency on @storybook/api or incompatibility with Storybook 6.5.16 HOT 1
- Docs and demo page is 404 HOT 8
- Support SB7 HOT 8
- Add support for type: 'markdown' HOT 1
- storybook 7. 0.12 not working with [email protected] HOT 2
- renderTarget: "tab" does not display the design tab HOT 2
- v7.0.0 is not published to npm registry
- Make it possible to use two design types simultaneously HOT 1
- Version 7.0.0 not available on npmjs HOT 1
- Warning in console after installing addon HOT 2
- Latest version(s) aren't being published HOT 1
- V7 release in npm HOT 1
- Error when trying to use figspec. HOT 1
- Addon not able to load images from local file paths HOT 1
- Add a prop like onToggle to Figma component?
- Support for storybook 7 HOT 5
- Can't use @storybook/addon-designs with NEXTjs 13 HOT 4
- Changelog & Git version tags HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from addon-designs.