[Suggestion] Stomp service should not call try_connect in constructor about ng2-stompjs HOT 7 CLOSED

First of all, a mode can be added where the try_connect is not called from the constructor. It can be controlled by a flag.

A longer answer to why it was not already done so:

It is assumed that many of the applications will use Angular's dependencies injection. In that case when another service or component receives it as a dependency it should be ready to use. For example in few of the applications we use the service from more than one components/services. In this case it gives a clean solution.

In my opinion, if you need application logic for initialization this service, you would not be able to use Angular's dependency injection mechanism.

In that case functions (possible exported) can be written that will create/initialize the service.

from ng2-stompjs.

If you want I can create a branch with alternate way to initialize the service, that will have a call to initialize the service (this will take the config). See, if that version gives you a better code structure.

Alternatively, create a minimal server (that I can clone and run, considering I have not programmed in Java since 2006) and Angular code (may be 2 different projects) and share it and we can collectively try to come up with a neat way to initialize the service.

from ng2-stompjs.

That's pretty much what I thought was the reason for this and it's legit reason imo, but it's still quite inconvinient in particular cases. Flag in config would be good quick fix, but wouldn't be very flexible. I feel that most elegant solution, according to SoC principle, would be to separate logic code that can be used standalone from simple Injectable service. So that one can, instead of using built in service, write his own implementation. I'll upload simple server and app I wrote for sake of demonstration to my github in the moment.

EDIT:
I uploaded my sample server and client.

from ng2-stompjs.

Thanks, I will have a look at it this weekend.

from ng2-stompjs.

Refactored, and made changes, please see my comments in the pull request.

from ng2-stompjs.

Can I close the issue now?

I will leave #13 open to finish example/documentation.

from ng2-stompjs.

Yes, feel free to close it. Thank you for assistance.

from ng2-stompjs.