Git Product home page Git Product logo

Comments (7)

jeremad avatar jeremad commented on June 8, 2024

Oh I think I can do that, I'll at least have a look

from stitchem.

w-m avatar w-m commented on June 8, 2024

Biggest difference: the APPLE_MACPORTS option in CMake currently adds lookup in /opt/local, whereas homebrew puts the files in /usr/local, IIRC.

from stitchem.

jeremad avatar jeremad commented on June 8, 2024

Ah... I misread the description, trickier than I thought. I still can have a look though

from stitchem.

jeremad avatar jeremad commented on June 8, 2024

Shouldn't we just drop external deps for linux and mac ?

from stitchem.

jeremad avatar jeremad commented on June 8, 2024

or may be use a CPP package manager like conan. But I'm not sure every lib we use has a receipe

from stitchem.

w-m avatar w-m commented on June 8, 2024

Shouldn't we just drop external deps for linux and mac ?

Yes. The APPLE_MACPORTS option was just a crutch to migrate away from external deps, when I wasn't sure whether it would work immediately everywhere.

For macOS and Linux we should use the official CMake find modules, wherever possible. If there's no module, there should be the possibility of adding /opt/local and /usr/local globally to the CMake search paths, so the paths don't have to be repeated in every find incarnation.

In the end CMake should find everything on its own without setting APPLE_MACPORTS or LINUX_PKG, but the user should still have the opportunity to override the package location with a manual option. I'm not sure what the current CMake best practices say how to do this, need to look at other projects.

As long as we don't have anything else on Windows, I'd like to keep the external_deps system working there.

from stitchem.

w-m avatar w-m commented on June 8, 2024

or may be use a CPP package manager like conan. But I'm not sure every lib we use has a receipe

For macOS and Linux I'd try to keep using the packages from the system package manager for simplicity reasons, wherever it makes sense.

To get a Windows build working conan is definitely an option. When I looked at that earlier I was disappointed to not find ffmpeg in the conan center (ffmpeg being one of the huge pain points on Windows), but there seem to be some 3rd party conan ffmpeg packages on GitHub, maybe they'll work.

from stitchem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.