ko.mapping.toJSON ignores options parameter about knockout.mapping HOT 10 CLOSED

Fixed problem with ko.mapping.fromJSON ignoring options. Closed by 10d0274.

from knockout.mapping.

This still doesn't work with toJS or toJSON. Basically my 'mapping' parameter (which I presume is options, since it's undocumented) gets ignored.

from knockout.mapping.

Can you add a reproduction scenario on jsfiddle?

from knockout.mapping.

Just so I'm not wasting time here: how should the mapping object (as given on the ko.mapping documentation page on the KO site) be passed to ko.toJS/ko.toJSON? I only see an options parameter for these functions, so I'm a bit confused.

from knockout.mapping.

It should simply be passed in as the only parameter, the options are automatically taken from the mapped object (inside your mapped object there is a ko_mapping property), e.g.:

var unmapped = ko.mapping.toJS(mappedViewModel);

from knockout.mapping.

Ah right... so I need to set the ko_mapping property to the 'mapping' object mentioned on the KO site. The KO site doesn't mention this at all! This just sounds like documentation needs to be updated. It's not very good atm to be fair. But thanks for the quick reply anyway.

from knockout.mapping.

No, this property is set automatically when you create a mapped object. The normal flow is something like:

var mappedViewModel = ko.mapping.fromJS(data);
// do stuff
var unmapped = ko.mapping.toJS(mappedViewModel);

mappedViewModel already contains the ko_mapping property, you don't need to do this manually. This is why it is not documented.

from knockout.mapping.

Oh, I see. And I think you mean that the mapping object can only be passed in on fromJS, per the Knockout documentation. e.g.

ko.mapping.fromJS(data, mapping)

but not the corresponding for the toJS/toJSON functions?

from knockout.mapping.

Yes, fromJS is intended to be used only with objects created with toJS. I hope this clarifies the problems you are seeing.

from knockout.mapping.

Thanks, all is clear now.

from knockout.mapping.