Git Product home page Git Product logo

Comments (4)

howsiwei avatar howsiwei commented on July 1, 2024

On an unrelated note, this is my preferred way of implementing Extended Euclidean algorithm (which is shorter and clearer but may be slightly slower).

void extEuclid(int& d, int& x, int& y, int a, int b) {
  if (a == 0) {
    d = b; x = 0; y = 1;
    return;
  }
  extEuclid(d, y, x, b % a, a);
  x -= b / a * y;
}

from cpbook-code.

howsiwei avatar howsiwei commented on July 1, 2024

int mod(ll a, int m) { // returns a (mod m)
return ((a%m) + m) % m; // ensure positive answer
}
is not needed in most places since in most intermediate steps it doesn't hurt to have negative values so we only need to ensure the positiveness at the very end. Using % instead of mod results in shorter and faster code.

from cpbook-code.

stevenhalim avatar stevenhalim commented on July 1, 2024

for better readability, the code can be written as follows.
tie(a, b) = tuple(b, a%b);
tie(x, xx) = tuple(xx, x-qxx);
tie(y, yy) = tuple(yy, y-q
yy);

Accepted, this is Pythonic way, and I am using C++17 anyway so ok


this is my preferred way of implementing Extended Euclidean algorithm

better not, we prefer iterative?

is not needed in most places since in most intermediate steps it doesn't hurt to have negative values
leave it :), it makes the explanation simpler, no need to chase for constant factor speed

from cpbook-code.

howsiwei avatar howsiwei commented on July 1, 2024

Ok, I'll change the multiple assignment code and leave the other two unchanged.

from cpbook-code.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.