Expand the view of the source when reviewing violations about p5-app-critique HOT 5 OPEN

I wonder if we could put a PR into Path::Tiny to extend the lines, to have a start_at option.

my $start = $violation_line - $config_plus_minus;
@violation_area = $file->lines(
    {
        start_at => $start < 0 ? 0 : $start,
        count    => ($config_plus_minus * 2) + 1
    }
);

Other wise we'll just have to make out own file splice subroutine.
(sorry for the edit spam)

from p5-app-critique.

Or thinking about it, File::Tie could be an option.

from p5-app-critique.

Actually I was thinking I could use the PPI nodes to get the info. Traverse up to the parent node, note the line number, render the parent node and trim the resulting string appropriately.

That said, I've not tried to do this yet :)

On Sep 4, 2016, at 22:39, Stuart Skelton [email protected] wrote:

Or thinking about it, File::Tie could be an option.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

from p5-app-critique.

I look forward to seeing that commit chain.

On 5 Sep 2016 8:35 a.m., "Stevan Little" [email protected] wrote:

Actually I was thinking I could use the PPI nodes to get the info.
Traverse up to the parent node, note the line number, render the parent
node and trim the resulting string appropriately.

That said, I've not tried to do this yet :)

On Sep 4, 2016, at 22:39, Stuart Skelton [email protected]
wrote:

Or thinking about it, File::Tie could be an option.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#27 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAc1FnhhxWD964OTbjQqEcLtG9RgCgc6ks5qm8Y5gaJpZM4J0l37
.

from p5-app-critique.

Haha, me too ;)

from p5-app-critique.