Git Product home page Git Product logo

Comments (9)

maluoi avatar maluoi commented on June 11, 2024 2

I'm about to wrap up some work on a tricky feature, but after that I think I owe UWP (like #981) a bit of time and attention. I'll definitely be looking into this next week!

from stereokit.

austinbhale avatar austinbhale commented on June 11, 2024 1

Nope, not a blocker! Thanks for fixing up those paths, it's much appreciated :) They'll get some traffic as I update to the new version

I'll close this one and make an issue over there because I repro'd in their OpenXR Tools official sample too with the latest runtime

from stereokit.

austinbhale avatar austinbhale commented on June 11, 2024

At times, we've also noticed that when MRC is activated in an SK app, it will crash unexpectedly. Closing the app or restarting usually resolves it. Unfortunately, I don't have any additional logs or debugging info yet

from stereokit.

austinbhale avatar austinbhale commented on June 11, 2024

Sweeet, thanks so much :)

from stereokit.

laultman avatar laultman commented on June 11, 2024

Likewise, thanks!

from stereokit.

austinbhale avatar austinbhale commented on June 11, 2024

On the version/0.3.10 branch using the following repro strategy:

  1. Restart the HoloLens 2 (every time!)
  2. Open the StereoKitTest_UWP app
  3. Start a MRC by saying the "Start Recording" HL2 command

I am still getting the error, but there's some hope! By commenting out the primary display's OpenXR composition layer when the secondary display is active, it successfully shows the viewfinder again but obviously nothing in StereoKit is rendered :D so I'm a little stuck here at the moment

Another quirk is if you're debugging it and set a breakpoint with the branch's code, it'll actually show up as it should so maybe SK is holding onto something with the primary display?

from stereokit.

maluoi avatar maluoi commented on June 11, 2024

Is this specifically about the viewfinder corners? Not a crash of any sort? I was able to see the corners not showing up the first time after restart, but I haven't seen any functional impact beyond that. The recording camera icon was still visible there too!

By commenting out the primary display's OpenXR composition layer when the secondary display is active, it successfully shows the viewfinder again but obviously nothing in StereoKit is rendered

I wonder if this is maybe a composition layer order issue? Maybe HL2's viewfinder composition layer sorts itself underneath SK's projection layer in some cases. If that is what's happening, then this might be very tricky to solve on our end. We don't really have control over ordering of composition layers outside of our own.

from stereokit.

austinbhale avatar austinbhale commented on June 11, 2024

This is mainly about the viewfinder corners! I haven't been able to repro a crash anymore. The performance in the StereoKit test app definitely looks normal (stable 30 FPS with MRC enabled). I tried the BasicXrApp in https://github.com/microsoft/OpenXR-MixedReality and it had the same issue, so maybe I'll drop it there. Perhaps it's an OpenXR-related bug since non OpenXR apps don't have this issue

from stereokit.

maluoi avatar maluoi commented on June 11, 2024

Okay, if that project also reproduces it, I'm not feeling so bad about this 😅 I guess this is not currently a blocker or anything at this point?

I did find/fix a couple sketchy code-paths with the secondary view when re-writing the swapchain code to support MSAA! I'm not so sure they'd have been common problems (or problems at all), but the new code does bullet-proof that feature a fair bit more than before. If you catch any hints of problems still coming from there with v0.3.10 though, lemme know!

from stereokit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.