Access column by name broken about sqlite.swift HOT 9 CLOSED

See this commit: 7fa9a57

SQLite column names can, unfortunately, collide, so I removed the values property on Statement to keep bugs from sneaking in (during something as common as a JOIN). Ideally, you use the typed query builder instead of raw SQL, which namespaces column names automatically, but you could add the behavior you relied on back using an extension:

extension Statement {
    /// :returns: A dictionary of column name to row value.
    public var values: [String: Binding?]? {
        if let row = row {
            var values = [String: Binding?]()
            for idx in 0..<row.count { values[columnNames[idx]] = row[idx] }
            return values
        }
        return nil
    }
}

Is there any reason you're running raw SQL directly and not using Expression and Query objects?

from sqlite.swift.

Answer to your last question: It was the quickest route to get our up going, and many copy/pastes later we ended up with it all over the place.

Seems like the extension has an issue with columnNames, since it's internal to the class? I get "use of unresolved identifier" when using the extension. The code works fine if added to the Statement class directly.

from sqlite.swift.

@minorbug Ah, you know what, I can see the value in making Statement.columnNames public. I'll try to get a commit in soon. In the meantime, feel free to mark it public in your extension.

from sqlite.swift.

Reopening to track making Statement.columnNames public.

from sqlite.swift.

@minorbug One last question, when you say "we ended up with it all over the place" are you referring to raw SQL? Or Expression structures? You should be able to manage your Expression structures in one place. That organizational detail is up to you, but here's an example:

struct User {
    static let id = Expression<Int>("id")
    static let email = Expression<String>("email")
    // etc.

    static var all: Query { /* return db["users"] */ }
}

// In practice:

let user = User.all.filter(User.id == 1).first!
// SELECT * FROM users WHERE id = 1 LIMIT 1

user[id] // 1
user[email] // "local@domain"

from sqlite.swift.

It's being used to port over an in-house Android app, which used raw sql, and for maintenance simplicity it was decided to make both versions look as close to each other as possible. We're not using any Expression structures right now, though I will use them in our the future Swift projects.

from sqlite.swift.

Thanks for the clarification! Good luck on your port 👍

from sqlite.swift.

raw SQL +1

from sqlite.swift.

Closed by c762538

from sqlite.swift.