Git Product home page Git Product logo

Comments (2)

emgre avatar emgre commented on July 20, 2024

I don't think I agree with this. Here are my points:

  • The Dispose (C#) / close (Java) pattern seems to model really well what we intend here. Similar to a file, if you just let it be collected by the garbage collector, we will close the connection. You should always close it manually when you really want to close it (like a file).
  • Same thing in C. It makes sense to gracefully shutdown by explicitly destroying the association. Destroying a pointer makes sense here. The lifetime of the pointer represents the lifetime of the association.
  • The destruction mechanism of this solution seems odd to me. We would pass a struct to the master saying "destroy this" but the struct would simply be copied?
  • Making it a struct means users will be able to pass in whatever association handle they like.

from dnp3.

jadamcrain avatar jadamcrain commented on July 20, 2024

I see your point regarding it not being an opaque type anymore. I just wish that there were something like in Rust where you can have a Copyable type, but keep the inner parts private.

from dnp3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.