When connecting the dnp3rs master to the OpenDNP3 outstation example, the startup inte

Infinite loop when receiving unknown data type about dnp3 HOT 1 CLOSED

stepfunc commented on July 2, 2024

Infinite loop when receiving unknown data type

from dnp3.

Comments (1)

emgre commented on July 2, 2024

After investigation, the solution would be to modify the AutoTaskState to Failure and avoid re-sending responses. It looks easy to do, however with the current design, the association is never notified of a failure of an AutoTask. Getting notified on failure is hard because we do not have access to the Association and the error may occur before the runner gets the Association

dnp3/dnp3/src/master/runner.rs

Lines 415 to 443 in 0e185d4

 match self 

 .validate_non_read_response(address, seq, io, reader, writer) 

 .await 

 { 

 // continue reading responses until timeout 

 Ok(None) => continue, 

 Ok(Some(response)) => { 

 match self.associations.get_mut(address) { 

 Err(x) => { 

 task.on_task_error(x.into()); 

 return Err(x.into()); 

 } 

 Ok(association) => { 

 association.process_iin(response.header.iin); 

 match task.handle(request_tx, association, response) { 

 None => return Ok(()), 

 Some(next) => { 

 task = next; 

 // break from the inner loop and execute the next request 

 break; 

 } 

 } 

 } 

 } 

 } 

 Err(err) => { 

 task.on_task_error(err); 

 return Err(err); 

 }

)

Need to discuss with @jadamcrain

from dnp3.

Infinite loop when receiving unknown data type about dnp3 HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	match self
	.validate_non_read_response(address, seq, io, reader, writer)
	.await
	{
	// continue reading responses until timeout
	Ok(None) => continue,
	Ok(Some(response)) => {
	match self.associations.get_mut(address) {
	Err(x) => {
	task.on_task_error(x.into());
	return Err(x.into());
	}
	Ok(association) => {
	association.process_iin(response.header.iin);
	match task.handle(request_tx, association, response) {
	None => return Ok(()),
	Some(next) => {
	task = next;
	// break from the inner loop and execute the next request
	break;
	}
	}
	}
	}
	}
	Err(err) => {
	task.on_task_error(err);
	return Err(err);
	}