Comments (5)
I'm happy to review a PR. I'd expect it to include the code, a unit test, and updates to the documentation. An example like the above should be sufficient.
But I would recommend using the 'every' facility for the example since you are dealing with a list of cidr_blocks. Something like this:
assertions:
- every:
key: "ingress[].cidr_blocks[]"
expressions:
- key: "@"
op: is-subnet
value: "10.0.0.0/8"
Is also looks like I no longer have write privileges on the repo @jeffb4
If you add me back, I can approve the PR. Otherwise I'll just review it and let you merge it.
from config-lint.
Thanks @lhitchon , that is helpful guidance. I will follow up with a PR sometime next week most likely.
from config-lint.
@rmorris1218 - Let me know if you end up not having time. I'm on a bit of a break at the moment, and I'd find that an interesting thing to work on. But I'm assuming you'd prefer to implement it yourself ;-)
from config-lint.
@lhitchon take a look at the changes i made.. let me know if it is too cumbersome to have the is-private-ip
operator, i just thought it was a good way of doing things
from config-lint.
also added a commit to account for that cannot be parsed into an IP object
from config-lint.
Related Issues (20)
- tf12 errors on parameter list format HOT 1
- Question about Filenames to scan. HOT 1
- Possibility to use an resource in conditions.
- Rules on Terraform variable and outputs
- Detect merged tags
- panic: runtime error: Index out of range [-1] HOT 1
- Comingling of locals
- error in homebrew-tap/Formula/mu-cli.rb to prevent installation with homebrew on MacOS HOT 4
- Config-lint is not loading .tfvars files in Terraform scripts HOT 1
- How to check nested terraform blocks HOT 1
- Incorrect rules are skipped without mention, giving the impression all is well HOT 1
- Allow comparison of multiple values
- Exclude files with regex?
- How do I integrate configlint-docker with gitlab-ci HOT 3
- Parse YAML files containing multiple documents?
- Support moved block syntax from Terraform 1.1
- Rule runs on everything when it should not.
- Brew installation failed with errors HOT 3
- Keys with dots/periods and slashes
- Question: Is this project still active / maintained
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from config-lint.