Git Product home page Git Product logo

Comments (5)

lhitchon avatar lhitchon commented on August 23, 2024 1

I'm happy to review a PR. I'd expect it to include the code, a unit test, and updates to the documentation. An example like the above should be sufficient.
But I would recommend using the 'every' facility for the example since you are dealing with a list of cidr_blocks. Something like this:

   assertions:
       - every:
             key: "ingress[].cidr_blocks[]"
             expressions:
                 - key: "@"
                    op: is-subnet
                    value: "10.0.0.0/8"

Is also looks like I no longer have write privileges on the repo @jeffb4
If you add me back, I can approve the PR. Otherwise I'll just review it and let you merge it.

from config-lint.

rmorris1218 avatar rmorris1218 commented on August 23, 2024

Thanks @lhitchon , that is helpful guidance. I will follow up with a PR sometime next week most likely.

from config-lint.

lhitchon avatar lhitchon commented on August 23, 2024

@rmorris1218 - Let me know if you end up not having time. I'm on a bit of a break at the moment, and I'd find that an interesting thing to work on. But I'm assuming you'd prefer to implement it yourself ;-)

from config-lint.

rmorris1218 avatar rmorris1218 commented on August 23, 2024

@lhitchon take a look at the changes i made.. let me know if it is too cumbersome to have the is-private-ip operator, i just thought it was a good way of doing things

from config-lint.

rmorris1218 avatar rmorris1218 commented on August 23, 2024

also added a commit to account for that cannot be parsed into an IP object

from config-lint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.