Git Product home page Git Product logo

Comments (5)

stefanwichmann avatar stefanwichmann commented on July 25, 2024

Hi,
this sounds like a reasonable request. We would have to change the semantics of the configuration file though and provide a migration for existing ones.

I suppose we could change the "ignore value" from 0 to -1 to allow 0 as an valid brightness value which will turn the light off (the minimum allowed value for brightness is actually 1).

One potential pitfall might be automatically switching off users lights for the first time but never turning them on automatically... what do you think?

from kelvin.

johnboyle87 avatar johnboyle87 commented on July 25, 2024

I suppose we could change the "ignore value" from 0 to -1 to allow 0 as an valid brightness value which will turn the light off (the minimum allowed value for brightness is actually 1).

I think this would work!

One potential pitfall might be automatically switching off users lights for the first time but never turning them on automatically... what do you think?

I hadn't thought of that... I think that this is okay though, so long as it's put in the documentation that once a light goes off Kelvin stops controlling it until it is turned back on. At least for me, this would be intended. I have tons of lights in one room and I love how Kelvin dims them as the night moves on, but to get the room even dimmer I'd like for some to turn off. Although I can't imagine a scenario when I would want this function, it could be rectified by including a feature similar to alarms in the standard hue app, where you program lights to turn on at a certain time.

from kelvin.

stefanwichmann avatar stefanwichmann commented on July 25, 2024

Alright, sound good to me.

I'm quite busy right now, but will try to give it a shoot in the next few days.

from kelvin.

stefanwichmann avatar stefanwichmann commented on July 25, 2024

Just pushed a fix for the issue to master. I will test the new functionality over the next few days in my house. If it works as expected I will publish a new release.

Give it a try if you like!

from kelvin.

stefanwichmann avatar stefanwichmann commented on July 25, 2024

Fixed in version 1.0.4

from kelvin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.