Comments (1)
The reason for this issue seems to be the triArea() proc and its wrong use:
func triArea*(a, b, c: Vector): float {.inline.} =
(b.x - a.x) * (c.y - a.y) - (b.y - a.y) * (c.x - a.x)
which is used by other procs
func ccw*(a, b, c: Vector): bool {.inline.} =
triArea(a, b, c) > 0
func rightOf(x: Vector; e: Edge): bool {.inline.} =
ccw(e.dest.point, e.org.point, x)
Due to numerical inaccuracy, for three nearly collinear points x, y, z, triArea(x, y, z) may be zero,
while triArea(y, x, z) is not zero.
To avoid inaccuracy issues and full symmetry, we should change rightOf() to
func rightOf(x: Vector; e: Edge): bool {.inline.} =
triArea(e.org.point, e.dest.point, x) < 0
We will do some more tests, and than apply this fix for sdt and sdt2 package. You may think about this issue yourself, and consult the related papers.
from cdt.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cdt.