IpRateLimitMiddleware can't parse caller IP about aspnetcoreratelimit HOT 8 CLOSED

I've published v1.0.5 on NuGet with a fix for this issue. Please let me know if it works for you.

Thanks

from aspnetcoreratelimit.

@carlos-anaya your use case is different. Please get v2.1.0 from NuGet and tell me if it's ok now.

Thanks

from aspnetcoreratelimit.

Can you view the IPs that are causing this? Maybe in the trace logs?

from aspnetcoreratelimit.

I was not able to get the IPs at the time. This happened after I did the first deployment of the application since implementing the rate limiter. It happened intermittently for several minutes after the deployment, however, 4 days later (now) it has not happened since. Weird...

from aspnetcoreratelimit.

One thing you could do is implement your own ReversProxyIpParser and do a try/catch/throw inside GetClientIp and append to the exception message all the IPs from the Request.Headers.

from aspnetcoreratelimit.

I forgot that the reason it stopped happening was that I pushed another hotfix to catch that exception.

I did as you suggested to log the X-Forwarded-For header. The IPs appear to be very standard IPs with a port on the end of them for some reason. ex: xx.xxx.xxx.159:28893, xx.xx.xxx.15:6555, and xx.xx.xxx.15:6558 (same IP as the previous but with different port this time).

NOTE: I replaced some of the numbers with x for privacy reasons.

One of the IPs logged this time is mine.

from aspnetcoreratelimit.

Hi, I ran into a similar issue, on appsettings.json I have:
"RealIpHeader": "X-Forwarded-For"
And the request header is:
X-Forwarded-For: 205.156.136.211, 192.168.29.47:54610
And I get the same exception: IpRateLimitMiddleware can't parse caller IP
I'm currently using v1.0.5
Thanks

from aspnetcoreratelimit.

Yup, it works. Many thanks for your quick answer @stefanprodan!

from aspnetcoreratelimit.