`reposition_legend()` removes `facet_rep_grid()` effect? about lemon HOT 6 CLOSED

from lemon.

Update

The root cause is that when turning legends off with d + theme(legend.position='hidden'), our garnish on the axis lines are removed for some reason. I will look into it some more.

Edit: reposition_legend uses the theme function to turn off legends when rendering the remainder of the plot...

from lemon.

This is a most excellent issue, you have found, and it has nothing to do with lemon.
It is actually ggplot2 that causes the problem when adding multiple themes, but I am not sure what the expected behaviour should be. I would say, at least not this!

The cause is that axis.line.x inherits from axis.line. When axis.line is element_blank() in theme_minimal() and theme_gray() (to name a few), rendering the following behaves as expected.

d <- ggplot(iris, aes(x = Petal.Width, fill = Species)) + 
  geom_histogram()
d + theme_minimal() + theme(axis.line.x=element_line(linetype='dashed'))

Now add a third theme for hiding the legend,

d + theme_minimal() + theme(axis.line.x=element_line(linetype='dashed')) + theme(legend.position='hidden')

and somehow axis.line overrides axis.line.x.

A workaround would be to stop axis.line overriding with an element_blank(), and blanking axis.line.y if required:

d + theme_minimal() + theme(axis.line = element_line(), axis.line.y=element_blank(), axis.line.x=element_line(linetype='dashed'))

An annoying solution for now. And it appears the same applies to axis.ticks.

I will try to use a different approach for hiding the legend to avoid this problem appearing in my package.

from lemon.

And finally, element_* has an argument inherit.blank:

Should this element inherit the existence of an element_blank among its parents? If TRUE the existence of a blank element among its parents will cause this element to be blank as well. If FALSE any blank parent element will be ignored when calculating final element state.

So yeah, that should probably do it.

https://ggplot2.tidyverse.org/reference/element.html

from lemon.

Wow, I didn't think this seemingly small issue would reach so far back into ggplot. Thank you very much for figuring this out. The workaround appears to work well. Thanks again!

from lemon.

You are most welcome! Sometimes we stumble over the smallest things. :) And I have looked at the help page for element_blank on countless occasions, but never realised the importance of that one argument.

from lemon.