Git Product home page Git Product logo

Comments (3)

stefanceriu avatar stefanceriu commented on August 19, 2024 1

I think it's safer if we just return early if the textStorage is in an editing state. I changed the resizeWithOldSuperviewSize method to the following and I can't reproduce the crash anymore, plus it does not seem to affect the minimap in any negative way.

Give it a shot please and let me know if it fixed the problem for you as well so I can make a new release.

- (void)resizeWithOldSuperviewSize:(NSSize)oldSize
{
    [super resizeWithOldSuperviewSize:oldSize];

    if(self.editorTextView.textStorage.editedMask) {
        return;
    }

    self.shouldAllowFullSyntaxHighlight = NO;

    CGRect frame = self.textView.bounds;
    frame.size.width = CGRectGetWidth(self.editorTextView.bounds);
    [self.textView setFrame:frame];

    [self updateOffset];
} 

from scxcodeminimap.

markeissler avatar markeissler commented on August 19, 2024

Yes. I think that has fixed it. I haven't had a crash yet typing in the same line that has guaranteed a crash every time before. Thanks.

from scxcodeminimap.

stefanceriu avatar stefanceriu commented on August 19, 2024

Awesome, thank you!

from scxcodeminimap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.