Git Product home page Git Product logo

Comments (7)

stefanceriu avatar stefanceriu commented on July 19, 2024

Thanks for reporting this, it was definitely not my intention to have it scroll horizontally.

from scxcodeminimap.

mike-lischke avatar mike-lischke commented on July 19, 2024

That was fast Stefan, thanks. But I think that's not the right solution. Atm the scrolling is so weird, it's practically unusuable when using the minimap for scrolling (even though the horizontal scrolling is fixed).

  1. Scrolling with a wheel mouse scrolls the minimap horizontally.
  2. Clicking in the minimap now only scrolls one page it seems, not to the position where I clicked on. It's a bit hard to say, because that constant scrolling of the minimap is so irritating.
  3. Dragging with the mouse (clicking somewhere in the minimap + holding the left mouse button, then move the mouse) moves the selection in a weird way. It looks as if it works delayed, especially when I change the direction (from up to down or vice versa) it still scrolls a while in the old direction. Very weird.

I believe fixing the minimap scrolling and then centering the selection area around the position where clicked (or dragged) would solve all these issues. Otherwise that plugin is a very nice addition and I'm thankful you created it.

from scxcodeminimap.

stefanceriu avatar stefanceriu commented on July 19, 2024

Okay, I think I have a hardware problem, let me get a proper mouse and get back to you on this :)

from scxcodeminimap.

stefanceriu avatar stefanceriu commented on July 19, 2024

Okay, so I changed a couple of things and I think you'll find it allot better now. What I did was:

  1. Disable horizontal scrolling from the minimap
  2. Link the horizontal scrolling of the main editor to the minimap
  3. Switched the way I center the selection view when the user clicks on the minimap

Can you please give it another go and let me know what you think ?

from scxcodeminimap.

mike-lischke avatar mike-lischke commented on July 19, 2024

1 and 2 are fine now. However point 3 is still a problem. When I click on the minimap the gray rect only moves a little (in a reasonable large file) instead of moving to the actual mouse position. Not even the part that was under the mouse when I clicked is scrolled into view (it only moves partially down, but is still not covered by the preview area). Dragging with the mouse still works only erratic. There seems to be no logic behind it. I can easily make the editor scrolling down while dragging the mouse up. Seems to be a function of the distance between mouse and the preview rect, and on which side (above or below the preview rect) is the mouse. Very weird.

from scxcodeminimap.

stefanceriu avatar stefanceriu commented on July 19, 2024

It seems that the problem is related to non-contiguous layouts and the layout manager not knowing the exact frames for all the glyphs. As far as I can tell this is a problem only on large source files and the only way to get it working properly is going through the whole file once, allowing both layout managers to calculate the full layouts.
Unfortunately I'm not really sure how to fix the problem so any ideas are more than welcome.

from scxcodeminimap.

stefanceriu avatar stefanceriu commented on July 19, 2024

Closing in favor of #52

from scxcodeminimap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.