Comments (2)
Yeah it's probably less likely the owner wants to do that, but true - it's technically possible.
transferOwnership
method is also public method, so the owner can transfer the ownership anytime they want.
claming minting cost would be better in terms of gas fee as well, but it would increase the risk of the contract being hacked.
I will discuss this issue more in the team and see if we're going to change the fee transfer design.
Thanks for your feedback :)
from dixel-v2-contract.
We've decided not to change this behavior because:
- The owner of a collection can always prevent people from minting by updating
whitelistOnly
feature anyway - Claiming can save some gas fee on minting, but adds more security risk and extra interfaces
Thanks for your feedback though! 👍🏻
from dixel-v2-contract.
Related Issues (19)
- Recommendation: Add a Burn event in a similar way to the Mint. HOT 1
- Mint and burn are missing nonReentrant modifier HOT 4
- Improper minting starts date validation. HOT 3
- Receive function in DixelClubV2NFT might get users ether stuck in the contract HOT 1
- SVGGenerator generates extra horizontal pixel - image dimensions becomes 24*25 HOT 2
- Save ~360,000 gas on collection creation by packing 2 pixels into one uint8 HOT 3
- The minting starts date can be changed even after minting.
- Consider using mapping instead of array HOT 17
- Split updateBeneficiary() in DixelClubV2Factory.sol HOT 1
- Optimize gas cost in for loop.
- _initializedAt bool instead of uint40 HOT 2
- Community Audit - Reward Distribution! 💸 HOT 15
- Withdraw? HOT 5
- backslash character (0x5c) can also be used to create invalid JSON HOT 3
- No need to traverse whitelist array twice when minting HOT 1
- There is no Ownable Contact in this project. HOT 1
- Pass position in whitelist when minting to save lots of gas HOT 2
- Whiltelisting logic should be fixed. HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dixel-v2-contract.